Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button too big in IE #78

Closed
anselm-urban opened this issue Oct 15, 2013 · 3 comments
Closed

Close button too big in IE #78

anselm-urban opened this issue Oct 15, 2013 · 3 comments
Labels
needs-feedback
Milestone
v1.1.0

Comments

@anselm-urban
Copy link
Contributor

Incorrect rendering in IE:
bild 2

Correct rendering in other browsers:
bild 1

As far as I no, this also happened in IE 9+, so it´s not only a bug in the IE11 developer preview.
By the way, the screenshots are taken from the example site!
@anselmh
Copy link
Contributor

anselmh commented Oct 15, 2013

Hi,
can you please elaborate what the misbehavior is here and in what IE versions it happens? From the screenshot I cannot really see the problem so it would be great if you could say what 'too big' means (by providing the calculated values or just a comparison screenshot).
Thank you for reporting this issue.

@drublic
Copy link
Owner

drublic commented Dec 5, 2013

It is important this happens on mobile. At the moment I don't feel like this is a big issue but we should tackle it with 1.1.0.

anselmh added a commit that referenced this issue Feb 2, 2014
@anselmh
Unify close btn on mobile (related #78)
bec6e63
@anselmh anselmh mentioned this issue Feb 2, 2014
Closed
@anselmh anselmh closed this as completed in 6c8ab26 Feb 3, 2014
@drublic
Copy link
Owner

drublic commented Feb 3, 2014

Shipped this. Thanks, man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-feedback
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Unify close btn on mobile (related #78) drublic/css-modal
3 participants
@anselmh @drublic @anselm-urban