Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions not working correctly in IE 11 (dev preview) and Firefox 25 (beta) #79

Closed
anselm-urban opened this issue Oct 15, 2013 · 8 comments
Milestone

Comments

@anselm-urban
Copy link
Contributor

In IE the closing transition isn´t displayed at all and in Firefox it´s sometimes displayed, sometimes not.

@anselmh
Copy link
Contributor

anselmh commented Oct 15, 2013

Hi, can you tell us what version you use here? Is it the master branch or wip-1.1.0? If it's the master branch, please check out the latest code from wip-1.1.0 and #70 and report back if it's solved or not with more details.

@anselm-urban
Copy link
Contributor Author

The problem occurs on http:https://drublic.github.io/css-modal/#modal-text
Not only is the transition not displayed at all, you also can´t click the close link (in the mobile version of the modal). To close the modal, you must click BELOW the button.

In Firefox, the closing transition is only sometimes displayed, the opening transition works fine. The problem also occurs on the official site.

I will try out the latest code from wip-1.1.0, hopefully it works.

@anselmh
Copy link
Contributor

anselmh commented Oct 16, 2013

Thanks for your feedback. This is most probably due to the fact that the page uses the older version and it is likely already fixed in upcoming v1.1. Until I confirmed that, I'm leaving this issue open.

@SantzDesign
Copy link

Guys it would be great if you could develop a way to integrate the animations you can see here: http:https://tympanus.net/codrops/2013/06/25/nifty-modal-window-effects/

To CSS Modal. Not to add them all but to bundle them in different pieces so that you're able to pick one and integrate it easily, just for the sake of speed and performance.

Thanks and luck.

@anselmh
Copy link
Contributor

anselmh commented Nov 21, 2013

Hi @SantzDesign, they're already in the v1.1.0 branch. You can find them here https://github.com/drublic/css-modal/blob/wip-1.1.0/_modal-core.scss#L333 and use them.

@drublic
Copy link
Owner

drublic commented Nov 22, 2013

@anselm-urban Does your bug still occur with the unstable version of CSS Modal?

@anselmh
Copy link
Contributor

anselmh commented Jan 29, 2014

Works fine (in my tests) so I'm going to close this issue now.

@anselmh anselmh closed this as completed Jan 29, 2014
@drublic
Copy link
Owner

drublic commented Jan 30, 2014

Thanks for testing @anselmh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants