Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo with pictures - are thumbnails meant to be clickable? #35

Closed
matt-bailey opened this issue May 15, 2013 · 7 comments
Closed

Demo with pictures - are thumbnails meant to be clickable? #35

matt-bailey opened this issue May 15, 2013 · 7 comments

Comments

@matt-bailey
Copy link

Very nice module btw :)

Is anything meant to happen on the demo with pictures - A slideshow, or perhaps the thumbnails are clickable? For me the modal opens and I see the main pic with thumbnails underneath, but nothing else happens.

I'm on OS X 10.8.3 and Chrome 26.0.1410.65.

@anselmh
Copy link
Contributor

anselmh commented May 15, 2013

Nope, this no bug, there is no interactivity on the example yet. I'm closing this for now but you're kindly invited to fork, edit and send a pull-request to add the feature you expected to see here.

@anselmh anselmh closed this as completed May 15, 2013
@drublic
Copy link
Owner

drublic commented May 15, 2013

Would you guys think it makes sense to add a kind of gallery for this modal? I mean for the page only.
Should be easy to do.

@drublic drublic reopened this May 15, 2013
@anselmh
Copy link
Contributor

anselmh commented May 15, 2013

Sorry for closing, @drublic. I do think it would make sense, yes.

@drublic
Copy link
Owner

drublic commented May 15, 2013

No worries man :) We could do this with some lines of JS but we would need all images in the proper size. I'll look into it :)

@matt-bailey
Copy link
Author

My thoughts are that at the moment it looks like a gallery, but doesn't behave like one (hence my original question). It's not a problem at all if you don't want to add any gallery functionality (after all, it's not what your module is about), but I would suggest maybe just laying out the images in a grid, rather than one main image and some thumbnails. Does that make sense do you think?

@drublic
Copy link
Owner

drublic commented May 15, 2013

@matt-bailey Makes a lot of sense. Actually we had this issue before (on Twitter I think). Anyway I think gallery functionality is pretty easy doable. So I'm implementing this tonight :D

@drublic
Copy link
Owner

drublic commented May 15, 2013

Nothing awesome, but it has a functionality now \o/ Micro gallery, hehe.
Thanks again for the discussion, people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants