Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashchange event not firing #182

Closed
jgadbois opened this issue Mar 12, 2015 · 5 comments
Closed

hashchange event not firing #182

jgadbois opened this issue Mar 12, 2015 · 5 comments
Labels
needs-feedback

Comments

@jgadbois
Copy link
Contributor

The hashchange event isn't firing for me in the modal css which in turn causes the cssmodal: events to fail. Currently working around by using the data-cssmodal-nohash property, but ideally I would like to remove that.
@jgadbois
Copy link
Contributor Author

Any ideas on this one?

@chilblane
Copy link

Are you using any iframes, such as to youtube? Having an issue where modal.js is trying to listen for hashchange within the youtube iframe and breaking as a result.

@drublic
Copy link
Owner

drublic commented Oct 4, 2015

@jgadbois Thanks for reporting. I could not find any bugs with the hashchange event. As @chilblane points out this might be some other script blocking the hashchange event.

@jgadbois
Copy link
Contributor Author

jgadbois commented Oct 5, 2015

I believe I was using youtube iframe embeds.

@drublic
Copy link
Owner

drublic commented Oct 5, 2015

Thank you for the quick feedback. I will close this issue. If you run into this behavior again, please let me know :)

@drublic drublic closed this as completed Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgadbois @drublic @chilblane