Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical centering of modal #164

Closed
ithilethiel opened this issue Oct 20, 2014 · 5 comments
Closed

Vertical centering of modal #164

ithilethiel opened this issue Oct 20, 2014 · 5 comments

Comments

@ithilethiel
Copy link

Hi, is the modal suppossed to automatically center itself on the screen? Just to know if there's something that isn't working or if I should do that via jquery myself.

Thanks!

@dhunink
Copy link

dhunink commented Oct 20, 2014

You did had a look at the demos, haven't you? The modal will center. Check out the CSS and Js sources if you want to understand why. Those files did have me a much better understanding of how things work.
Not to be hostile, but if you're experiecing trouble to get things working like they work in the demo, you probably be better of asking your question on a forum like stackoverflow.com, since github is mainly the place to discuss bugs and feature improvements.

@ithilethiel
Copy link
Author

The thing is, in the demos, I see them not being vertically centered.

@ithilethiel
Copy link
Author

http:https://drublic.github.io/css-modal/ They are not being vertically centered in Chrome, Firefox or IE. Haven't checked in other browsers.

@dhunink
Copy link

dhunink commented Oct 20, 2014

You're right. I've read you're message to quickly and thought you were talking about horizontal centering. My mistake, sorry.
Vertical centering is not an option right now. I'd suggest opening an suggestion for feature improvement and in the mean time dive into the css/JS files and ask for help on stack overflow if you don't manage it yourself. Pretty sure it can be done (since i've seen it before in other modal libraries).

@ithilethiel
Copy link
Author

ok :) I was about to do it via jquery.
I'll open a suggestion for feature improvement later. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants