-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close-button style #114
Comments
Currently not. What is the problem of the current implementation? |
The ability to readily implement a design given to me by our designers... I've got it, now, but it's kind of hacky. |
I think this has to stay this way. You can overwrite the values in |
I simply mean an X-button that is not hovering outside the dialog itself. Standard as in, it looks approximately like every other dialog window you see. |
You can do this with not too much effort by using another div or similar to apply the background to and then shifting the close button into the dialog. But it's unfortunately not something that could be offered as a direct option. |
It's honestly been a long time and I don't remember the details. It makes more sense to locate the div inside and shift it out than the reverse. I think the problem may have had to do with what was contained in what, either for selector purposes or units of measure. Either way, I am no longer invested. |
It appears that you use the container for the close button to also 'dim out' the background of the modal. It would be nice to have a more 'standard' X-button (within the dialog) as an option. Is there an easy way to modify the CSS to allow this?
The text was updated successfully, but these errors were encountered: