Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close-button style #114

Closed
myndzi opened this issue May 16, 2014 · 6 comments
Closed

Close-button style #114

myndzi opened this issue May 16, 2014 · 6 comments
Milestone

Comments

@myndzi
Copy link

myndzi commented May 16, 2014

It appears that you use the container for the close button to also 'dim out' the background of the modal. It would be nice to have a more 'standard' X-button (within the dialog) as an option. Is there an easy way to modify the CSS to allow this?

@drublic
Copy link
Owner

drublic commented May 20, 2014

Currently not. What is the problem of the current implementation?

@myndzi
Copy link
Author

myndzi commented May 20, 2014

The ability to readily implement a design given to me by our designers...

I've got it, now, but it's kind of hacky.

@drublic drublic added this to the v1.2.0 milestone May 22, 2014
@drublic drublic modified the milestones: v.1.3.0, v1.2.0 Nov 19, 2014
@drublic
Copy link
Owner

drublic commented Nov 20, 2014

I think this has to stay this way. You can overwrite the values in _modal-theme.scss in case it's needed.
What exactly do you mean by more "standard" close button?

@myndzi
Copy link
Author

myndzi commented Dec 1, 2014

I simply mean an X-button that is not hovering outside the dialog itself. Standard as in, it looks approximately like every other dialog window you see.

@anselmh
Copy link
Contributor

anselmh commented Dec 1, 2014

You can do this with not too much effort by using another div or similar to apply the background to and then shifting the close button into the dialog. But it's unfortunately not something that could be offered as a direct option.

@myndzi
Copy link
Author

myndzi commented Dec 1, 2014

It's honestly been a long time and I don't remember the details. It makes more sense to locate the div inside and shift it out than the reverse. I think the problem may have had to do with what was contained in what, either for selector purposes or units of measure. Either way, I am no longer invested.

@myndzi myndzi closed this as completed Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants