Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_inputs argument #227

Open
NoName115 opened this issue Apr 11, 2018 · 3 comments
Open

user_inputs argument #227

NoName115 opened this issue Apr 11, 2018 · 3 comments

Comments

@NoName115
Copy link

I think that 'user_inputs' argument is not working correctly, e.g.

>>> from zxcvbn import zxcvbn
>>> zxcvbn('i love you')['score']
3
>>> zxcvbn('i love you', user_inputs=['love'])['score']
3
>>> zxcvbn('i love you', user_inputs=['love', 'you'])['score']
3
>>> zxcvbn('i love you', user_inputs=['i', 'love', 'you'])['score']
3
@chunty
Copy link

chunty commented Jun 12, 2018

Yes I agree.

zxcvbn('sherlock holmes')['score']
3
zxcvbn('sherlock holmes',['sherlock', 'holmes'])['score']
3
zxcvbn('sherlock holmes',['sherlock holmes'])['score']
0

So it does work but ONLY if the password exactly matches an option in the user inputs which sort of defeats the object of passing the form fields in.

@chunty
Copy link

chunty commented Jun 12, 2018

I also suspect the problem is further compounded by this issue #216.

@TheHans255
Copy link

It looks like #216 is exactly the problem here - the spaces are being integrated as part of the surrounding words, causing those words not to match the user inputs dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants