Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web version of the sdk should use the browser crypto api #1115

Open
ta32 opened this issue May 31, 2023 · 1 comment
Open

web version of the sdk should use the browser crypto api #1115

ta32 opened this issue May 31, 2023 · 1 comment

Comments

@ta32
Copy link

ta32 commented May 31, 2023

Why is this feature valuable to you? Does it solve a problem you're having?
The web version of the JavaScript SDK is importing the NodeJs (server) crypto module - the web-pack fallback for this is https://github.com/browserify/crypto-browserify

This results in a large bundle size for your web-app. It should be possible to replace this with the native browser crypto API's
https://developer.mozilla.org/en-US/docs/Web/API/Crypto

Also I am not sure if its safe to continue using this fallback for the future especially for something like cryptography.

Describe the solution you'd like
The SDK should detect its being used in the browser and use the https://developer.mozilla.org/en-US/docs/Web/API/Crypto
API.

Describe alternatives you've considered
None

Additional context
related issues
#991
#614

@greg-db
Copy link
Contributor

greg-db commented May 31, 2023

Thanks for writing this up! I'll ask the team to update this accordingly, though I can't promise if/when this would be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants