Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(missing feature) add support to check organization membership in gitea driver #262

Closed
cod3rboy opened this issue Aug 4, 2023 · 0 comments · Fixed by #263
Closed

(missing feature) add support to check organization membership in gitea driver #262

cod3rboy opened this issue Aug 4, 2023 · 0 comments · Fixed by #263

Comments

@cod3rboy
Copy link
Contributor

cod3rboy commented Aug 4, 2023

Organization service in gitea driver has missing implementation for FindMembership method.
At line - https://github.com/drone/go-scm/blob/master/scm/driver/gitea/org.go#L25

func (s *organizationService) FindMembership(ctx context.Context, name, username string) (*scm.Membership, *scm.Response, error) {
	return nil, nil, scm.ErrNotSupported
}

Due to this, CheckMembership acl middleware is failing for all gitea users trying to access resources in their organization namespace.
This causes organization secrets and templates pages of Drone CI dashboard to crash.

@cod3rboy cod3rboy changed the title (missing feature) gitea driver does not have support for checking organization membership (missing feature) add support to check organization membership in gitea driver Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant