Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dump response #119

Closed
bradrydzewski opened this issue Jul 30, 2021 · 0 comments
Closed

Fix dump response #119

bradrydzewski opened this issue Jul 30, 2021 · 0 comments

Comments

@bradrydzewski
Copy link
Member

Short term we should fix the DumpResponse to actually dump the response. https://github.com/drone/go-scm/blob/master/scm/client.go#L168

-c.DumpResponse(res, true)
+out, _ := c.DumpResponse(res, true)
+println(string(out))

Longer term we should change DumpResponse so that it does not return a byte array, and instead is responsible for dumping the actual contents to stdout, similar to https://github.com/drone/go-login/blob/master/login/logger/dumper.go
@bradrydzewski bradrydzewski changed the title fix dump response Fix dump response Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradrydzewski