Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 compatiablity tracker #2037

Open
marty1885 opened this issue May 25, 2024 · 4 comments
Open

HTTP/2 compatiablity tracker #2037

marty1885 opened this issue May 25, 2024 · 4 comments
Labels

Comments

@marty1885
Copy link
Member

This issue is used to track our HTTP/2 client's compatibility. Please comment here which endpoint(s) you are using so we can collect a list of know compatible endpoints. This issues will be closed upon HTTP/2 leaving beta. Currently known working hosts:

  • google.com
  • example.com
  • clehaxze.tw (my blog, runs over nginx)
  • http2cdn.cdnsun.com
  • nasdaq.com
  • www.nchc.org.tw
  • amd.com
  • archlinux.org
  • openai.com
  • cloudflare.com
  • ietf.org
  • generativelanguage.googleapis.com
@nqf
Copy link

nqf commented May 29, 2024

Did I use it wrong?

export SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt

    auto client = HttpClient::newHttpClient("https://www.google.com");
    auto req = HttpRequest::newHttpRequest();
    client->sendRequest(
        req, [](ReqResult result, const HttpResponsePtr& response) {
            if (result != ReqResult::Ok) {
                std::cout
                    << "error while sending request to server! result: "
                    << result << std::endl;
                return;
            }

            std::cout << "receive response!:" << response->getBody() << std::endl;
        });

error while sending request to server! result: Bad response from server

@marty1885
Copy link
Member Author

marty1885 commented May 29, 2024

@nqf Ohh yeah... there 0is a bug in the HPACK decoder that fails to decode what we get from google.com. Let me debug it...

Update: The issue seems to be me not handling setting max table list size.. Checking the RFC

@marty1885
Copy link
Member Author

marty1885 commented May 29, 2024

@nqf Can you try #2045 ? I fixed it and confirmed it works on my machine. Turns our the issue is an unexpected empty path.

@nqf
Copy link

nqf commented May 30, 2024

@marty1885 thanks, Confirmed that it can work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants