Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port RandomAccessStream to Java #357

Open
kwhopper opened this issue Aug 4, 2018 · 3 comments
Open

Port RandomAccessStream to Java #357

kwhopper opened this issue Aug 4, 2018 · 3 comments
Assignees

Comments

@kwhopper
Copy link
Collaborator

kwhopper commented Aug 4, 2018

@drewnoakes If you decide to go with some version of drewnoakes/metadata-extractor-dotnet#130 I would be happy to attempt a port to Java. My Java skills aren't perfect though.

@Nadahar
Copy link
Contributor

Nadahar commented Aug 4, 2018

A reader implementation that doesn't have to read everything into memory would be a great improvement in my opinion 👍 Some images are really slow to parse.

@kwhopper
Copy link
Collaborator Author

kwhopper commented Aug 4, 2018

@Nadahar Could you point out some of the images that are slow? I could run some performance tests on the .NET PR vs .NET vs Java and see if RandomAccessStream helps speed things up. That might suggest improvements also.

I don't claim that RAS is perfect or will solve all the performance problems, but I do think that development in the library is difficult because of how fragmented data reading has become. Consolidating the reading layer feels like a necessity. If nothing else RAS puts it all in one place and tuning can be done there independent of the format readers.

@Nadahar
Copy link
Contributor

Nadahar commented Aug 4, 2018

@kwhopper I think that any large JPEG would do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants