Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): slide editor should use a different id from sheet cell editor #3008

Merged
merged 6 commits into from
Aug 10, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 10, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from jikkai as a code owner August 10, 2024 06:31
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 26.10%. Comparing base (d08f436) to head (4331dab).
Report is 1 commits behind head on dev.

Files Patch % Lines
...des-ui/src/services/slide-editor-bridge.service.ts 0.00% 10 Missing ⚠️
...src/controllers/slide-editing.render-controller.ts 0.00% 5 Missing ⚠️
...ntrollers/slide-editor-bridge.render-controller.ts 0.00% 4 Missing ⚠️
...-ui/src/views/editor-container/EditorContainer.tsx 0.00% 2 Missing ⚠️
...es-ui/src/controllers/uni-slides-ui.controller.tsx 0.00% 1 Missing ⚠️
.../docs/src/services/doc-skeleton-manager.service.ts 0.00% 1 Missing ⚠️
packages/slides-ui/src/const.ts 0.00% 1 Missing ⚠️
...s/slides-ui/src/controllers/slide-ui.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3008      +/-   ##
==========================================
- Coverage   26.10%   26.10%   -0.01%     
==========================================
  Files        1907     1909       +2     
  Lines      101820   101828       +8     
  Branches    21739    21741       +2     
==========================================
  Hits        26585    26585              
- Misses      75235    75243       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai changed the title fix(editor): slide editor should use a differnt id from sheet cell editor fix(editor): slide editor should use a different id from sheet cell editor Aug 10, 2024
@wzhudev wzhudev merged commit b95d337 into dev Aug 10, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/slide-editor-id branch August 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants