Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-ui): support drawing print #2418

Merged
merged 9 commits into from
Jun 6, 2024
Merged

feat(sheets-ui): support drawing print #2418

merged 9 commits into from
Jun 6, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 4, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (515e0ae) to head (25da5f0).
Report is 2 commits behind head on dev.

Current head 25da5f0 differs from pull request most recent head 2c5f326

Please upload reports for the commit 2c5f326 to get more accurate results.

Files Patch % Lines
.../drawing-ui/src/services/drawing-render.service.ts 0.00% 51 Missing ⚠️
...c/controllers/sheet-drawing-printing.controller.ts 0.00% 49 Missing ⚠️
...heets-ui/src/services/print-interceptor.service.ts 0.00% 9 Missing ⚠️
...wing-ui/src/controllers/image-update.controller.ts 0.00% 7 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 3 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 3 Missing ⚠️
...-render/src/components/sheets/extensions/marker.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/context.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2418      +/-   ##
==========================================
- Coverage   27.13%   27.09%   -0.05%     
==========================================
  Files        1646     1649       +3     
  Lines       83040    83123      +83     
  Branches    17211    17227      +16     
==========================================
- Hits        22536    22525      -11     
- Misses      60504    60598      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 6, 2024
@weird94 weird94 merged commit f24cace into dev Jun 6, 2024
8 of 9 checks passed
@weird94 weird94 deleted the feat/drawing-print branch June 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants