Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): ui dependency in sort #2580

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix(sheet): ui dependency in sort #2580

merged 2 commits into from
Jun 21, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 21, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.04%. Comparing base (7854249) to head (dc49d2e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2580   +/-   ##
=======================================
  Coverage   27.04%   27.04%           
=======================================
  Files        1677     1677           
  Lines       84762    84762           
  Branches    17626    17626           
=======================================
  Hits        22925    22925           
  Misses      61837    61837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhongz yuhongz changed the title fix: ui dependency in sort fix(sheet): ui dependency in sort Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@yuhongz yuhongz merged commit 1c67036 into dev Jun 21, 2024
10 checks passed
@yuhongz yuhongz deleted the yuhongz/fix-ui-dependency branch June 21, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants