Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollInfo should not save into snapshot #2514

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Jun 13, 2024

because scrollInfo is differ by different people.

https://github.com/dream-num/univer-pro/issues/1151

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

because scrollInfo is differ by different people.
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 13, 2024
@lumixraku lumixraku requested a review from Dushusir June 13, 2024 12:27
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.16%. Comparing base (ca76011) to head (c35045d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2514   +/-   ##
=======================================
  Coverage   27.16%   27.16%           
=======================================
  Files        1653     1653           
  Lines       83357    83350    -7     
  Branches    17263    17260    -3     
=======================================
+ Hits        22642    22643    +1     
+ Misses      60715    60707    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 14, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 14, 2024
@lumixraku lumixraku merged commit 782c7dc into dev Jun 14, 2024
8 of 9 checks passed
@lumixraku lumixraku deleted the fix/do-not-save-scroll-to-snapshot branch June 14, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants