feat: add scrollLeftTop for sheet snapshot #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumixraku
requested review from
DR-Univer,
jikkai,
Jocs and
wzhudev
as code owners
lumixraku
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2414 +/- ##
==========================================
- Coverage 27.12% 27.11% -0.02%
==========================================
Files 1653 1653
Lines 83228 83300 +72
Branches 17234 17254 +20
==========================================
+ Hits 22574 22585 +11
- Misses 60654 60715 +61 ☔ View full report in Codecov by Sentry. |
View Deployment
🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 |
lumixraku
added
feature request
zhaolixin7
added
qa:verified
lumixraku
force-pushed
the
feat/add-scrollLeftTop-sheet-snapshot
branch
4 times, most recently
from
6bbdc5f
to
9d09327
Compare
* feat: add scrollLeftTop for sheet snapshot * fix: set-frozen test case need ScrollManagerService -> SheetSkeletonManagerService * fix: switch tab sync state in scene and viewport fix: revert back _updateViewZoom chore: import SHEET_VIEWPORT_KEY from engine-render
chore: do not change scrollXY when viewport width is negative
lumixraku
force-pushed
the
feat/add-scrollLeftTop-sheet-snapshot
branch
from
9d09327
to
796352c
Compare
Dushusir
reviewed
Jun 7, 2024
| } | ||
|
|
||
| removeScrollBar() { | ||
| this._scrollBar = null; | ||
| } | ||
|
|
||
| /** | ||
| * 和 resetSizeAndScrollBar 不同 | ||
| * 和 resetCanvasSizeAndScrollbar 不同 | ||
| * 此方法是调整冻结行列设置时 & 初始化时触发, resize window 时并不会触发 |
There was a problem hiding this comment.
Recommended comments are all changed to English
Dushusir
approved these changes
Jun 7, 2024
lumixraku
force-pushed
the
feat/add-scrollLeftTop-sheet-snapshot
branch
from
796352c
to
4d7082b
Compare
lumixraku
added a commit
that referenced
this pull request
Jun 17, 2024
* feat: add scrollLeftTop for sheet snapshot (#2348) * feat: add scrollLeftTop for sheet snapshot * fix: set-frozen test case need ScrollManagerService -> SheetSkeletonManagerService * fix: switch tab sync state in scene and viewport * fix: revert back _updateViewZoom * chore: import SHEET_VIEWPORT_KEY from engine-render * fix: when update scroll should consider scale factor * chore: do not change scrollXY when viewport width is negative * test: should use sheetSkService from cur render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2116
#2116
Add scrollLeft scrollTop to sheet snapshot after scroll command, and restore the scrolling state when changing tabs of sheet.
check scrollLeft and scrollTop value in
univer._univerInstanceService.getFocusedUnit()._snapshotPull Request Checklist