Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets): add set workbook name command #2249

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 16, 2024

This PR adds a new command to UniverSheet. This command should be intercepted by the formula system.

@wzhudev wzhudev requested a review from DR-Univer as a code owner May 16, 2024 03:28
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 30.84%. Comparing base (19f1dbc) to head (2414662).

Files Patch % Lines
...src/commands/commands/set-workbook-name.command.ts 0.00% 12 Missing ⚠️
...c/commands/mutations/set-workbook-name.mutation.ts 0.00% 6 Missing ⚠️
packages/core/src/sheets/workbook.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2249      +/-   ##
==========================================
- Coverage   30.84%   30.84%   -0.01%     
==========================================
  Files        1358     1360       +2     
  Lines       70668    70690      +22     
  Branches    14870    14873       +3     
==========================================
+ Hits        21799    21801       +2     
- Misses      48869    48889      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit 3c24cdd into dev May 16, 2024
8 checks passed
@wzhudev wzhudev deleted the feat/rename-workbook branch May 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant