Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the content is not display when enter edit cell #2245

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: the content is not display when enter edit cell #2245

merged 1 commit into from
May 15, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 15, 2024

@Jocs Jocs marked this pull request as ready for review May 15, 2024 08:14
wzhudev
wzhudev approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.84%. Comparing base (9636037) to head (639f670).

Files Patch % Lines
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2245   +/-   ##
=======================================
  Coverage   30.84%   30.84%           
=======================================
  Files        1358     1358           
  Lines       70668    70668           
  Branches    14870    14870           
=======================================
  Hits        21799    21799           
  Misses      48869    48869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs merged commit 08f41cf into dev May 15, 2024
9 checks passed
@Jocs Jocs deleted the fix/edit-cell branch May 15, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jocs @wzhudev