Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifecycle event handling in plugin holder #2244

Merged
merged 3 commits into from
May 15, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 15, 2024

No description provided.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.86%. Comparing base (2739fba) to head (a28ea10).
Report is 1 commits behind head on dev.

Files Patch % Lines
...-ui/src/services/sheet-skeleton-manager.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2244   +/-   ##
=======================================
  Coverage   30.85%   30.86%           
=======================================
  Files        1358     1358           
  Lines       70616    70630   +14     
  Branches    14853    14855    +2     
=======================================
+ Hits        21791    21798    +7     
- Misses      48825    48832    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev requested a review from jikkai as a code owner May 15, 2024 04:31
@wzhudev wzhudev merged commit 85af642 into dev May 15, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/plugin-holder-lifecycle branch May 15, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant