Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the cursor is displayed incorrectly in the presence of bg color #2218

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: the cursor is displayed incorrectly in the presence of bg color #2218

merged 1 commit into from
May 14, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 11, 2024 •
edited
Loading

@Jocs Jocs marked this pull request as ready for review May 11, 2024 02:56
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 11, 2024
@Jocs Jocs changed the title fix: the cursor is displayed incorrectly in the presence of a backgro… fix: the cursor is displayed incorrectly in the presence of bg color May 11, 2024
@codecov Codecov
Copy link

codecov bot commented May 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.73%. Comparing base (184b98b) to head (39d132b).
Report is 2 commits behind head on dev.

Files Patch % Lines
...r/src/components/docs/text-selection/text-range.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2218   +/-   ##
=======================================
  Coverage   30.73%   30.73%           
=======================================
  Files        1273     1273           
  Lines       70213    70213           
  Branches    14809    14809           
=======================================
  Hits        21582    21582           
  Misses      48631    48631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

DR-Univer
DR-Univer reviewed May 11, 2024
View reviewed changes
packages/engine-render/src/components/docs/text-selection/text-range.ts
@@ -45,7 +45,7 @@ const ID_LENGTH = 6;
const BLINK_ON = 500;
const BLINK_OFF = 500;

export const TEXT_RANGE_LAYER_INDEX = 1;
export const TEXT_RANGE_LAYER_INDEX = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和其他index统一到一个地方去申明 后期维护起来容易些。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他 docs 相关的 layer index 都在 docs module 中，这个好像还不能直接放过去，因为这个是在render-engine 使用，全部提到 core 里面维护？

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 11, 2024
wzhudev
wzhudev approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 84620d4 into dev May 14, 2024
12 checks passed
@wzhudev wzhudev deleted the fix/cursor-display branch May 14, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DR-Univer DR-Univer DR-Univer left review comments

@wzhudev wzhudev wzhudev approved these changes

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jocs @wzhudev @DR-Univer @oumomomo