Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): allow menu scroll when it over viewport #2215

Merged
merged 2 commits into from
May 10, 2024

Conversation

siam-ese
Copy link
Contributor

To resolve the below problem

WeChatWorkScreenshot_9b0d8287-a901-45dc-9e0a-5e71b988f74c

The height of the dropdown menu on the Toolbar is greater than the height of the viewport.
It brings an unexpected scroller.

Copy link

github-actions bot commented May 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siam-ese siam-ese merged commit 184b98b into dream-num:dev May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants