Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): formula string results are displayed as regular strings #2206

Merged
merged 4 commits into from
May 13, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented May 9, 2024

  1. close [Bug] When the formula result is equal to "0", no error message is expected #2194
    如何测试?
    场景 1. 输入 =IF(1,"0"),不会再出现强制字符串角标
    场景 2. 输入 #N/A 不会再出现公式报错提醒

  2. close https://github.com/dream-num/univer-pro/issues/661

  3. close https://github.com/dream-num/univer-pro/issues/658
    如何测试?(2,3 是同一个问题)
    整两个货币格式或者日期格式的单元格,用公式做一下加减乘除即可

  4. LOWER 函数支持处理 TRUE FALSE 为小写
    错误情况:显示了TRUE
    企业微信截图_17153306109868

    实际情况:显示true

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.78%. Comparing base (7f1540f) to head (1b94846).

Files Patch % Lines
...ages/engine-formula/src/engine/utils/numfmt-kit.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2206      +/-   ##
==========================================
+ Coverage   30.77%   30.78%   +0.01%     
==========================================
  Files        1275     1275              
  Lines       70192    70204      +12     
  Branches    14789    14790       +1     
==========================================
+ Hits        21600    21614      +14     
+ Misses      48592    48590       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review May 10, 2024 12:23
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 10, 2024
@univer-bot
Copy link

univer-bot bot commented May 10, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(formula): formula string results are displayed as regular strings

Title: fix(formula): formula string results are displayed as regular strings


  1. close [Bug] When the formula result is equal to "0", no error message is expected #2194
    How to test?
    Scenario 1. Enter =IF(1,"0"), and the mandatory string subscript will no longer appear.
    Scenario 2. Enter #N/A and the formula error reminder will no longer appear.

  2. close https://github.com/dream-num/univer-pro/issues/661

  3. close https://github.com/dream-num/univer-pro/issues/658
    How to test? (2,3 are the same question)
    Use formulas to add, subtract, multiply and divide two cells in currency format or date format.

  4. The LOWER function supports processing TRUE FALSE as lowercase
    Error condition: TRUE is shown
    Enterprise WeChat screenshot_17153306109868

    Actual situation: display true

@zhaolixin7
Copy link

@Dushusir 问题2、3 未修复
image

@univer-bot
Copy link

univer-bot bot commented May 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir Issues 2 and 3 are not fixed
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 11, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 11, 2024
@univer-bot univer-bot bot removed the qa:rejected label May 11, 2024
@Dushusir Dushusir merged commit 1d1a45f into dev May 13, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bug0509 branch May 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When the formula result is equal to "0", no error message is expected
4 participants