Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add registerPlugin config types #1484

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

gityoog
Copy link
Contributor

@gityoog gityoog commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.
  1. Add type checking for Plugin parameters
univer.registerPlugin(UniverUIPlugin, {
  container: "app",
  header: true,
  toolbar: true,
  footor: true, // Error, 'footor' does not exist in type <...>. Did you mean to write 'footer'?
})
  1. IUniverFormulaEngine.config can be optional
// packages/engine-formula/src/plugin.ts#L95
useFactory: () => this._injector.createInstance(FormulaController, this._config?.function)
  1. standalone is a deprecated property in UniverDocsPlugin

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.59%. Comparing base (885ba4b) to head (9cb0589).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1484   +/-   ##
=======================================
  Coverage   32.59%   32.59%           
=======================================
  Files         905      905           
  Lines       50121    50121           
  Branches    10431    10431           
=======================================
  Hits        16335    16335           
  Misses      33786    33786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@wzhudev wzhudev merged commit a5a073c into dream-num:dev Mar 22, 2024
8 checks passed
Jocs pushed a commit that referenced this pull request Mar 23, 2024
* fix(docs): remove deprecated property `standalone`

* feat(engine-formula): make IUniverFormulaEngine.function optional

* feat(core): add registerPlugin config types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants