diff --git a/packages-experimental/uniui/src/controllers/uniui-desktop.controller.tsx b/packages-experimental/uniui/src/controllers/uniui-desktop.controller.tsx index 9b0933801e..1930e2ffb1 100644 --- a/packages-experimental/uniui/src/controllers/uniui-desktop.controller.tsx +++ b/packages-experimental/uniui/src/controllers/uniui-desktop.controller.tsx @@ -15,11 +15,10 @@ */ import { Disposable, LifecycleService, LifecycleStages, toDisposable } from '@univerjs/core'; -import { IRenderManagerService } from '@univerjs/engine-render'; import type { IWorkbenchOptions } from '@univerjs/ui'; -import { BuiltInUIPart, CanvasPopup, FloatDom, ILayoutService, IUIPartsService } from '@univerjs/ui'; +import { BuiltInUIPart, CanvasPopup, FloatDom, IUIPartsService } from '@univerjs/ui'; import type { IDisposable } from '@wendellhu/redi'; -import { Inject, Injector, Optional } from '@wendellhu/redi'; +import { Inject, Injector } from '@wendellhu/redi'; import { connectInjector } from '@wendellhu/redi/react-bindings'; import React from 'react'; import { delay, filter, take } from 'rxjs'; @@ -31,11 +30,9 @@ const STEADY_TIMEOUT = 3000; export class UniverUniUIController extends Disposable { constructor( - @IRenderManagerService private readonly _renderManagerService: IRenderManagerService, @Inject(Injector) private readonly _injector: Injector, @Inject(LifecycleService) private readonly _lifecycleService: LifecycleService, - @IUIPartsService private readonly _uiPartsService: IUIPartsService, - @Optional(ILayoutService) private readonly _layoutService?: ILayoutService + @IUIPartsService private readonly _uiPartsService: IUIPartsService ) { super(); this._initBuiltinComponents(); diff --git a/packages/sheets/src/commands/operations/selection.operation.ts b/packages/sheets/src/commands/operations/selection.operation.ts index 4654d729d9..a745ef88b6 100644 --- a/packages/sheets/src/commands/operations/selection.operation.ts +++ b/packages/sheets/src/commands/operations/selection.operation.ts @@ -34,9 +34,7 @@ export const SetSelectionsOperation: IOperation = type: CommandType.OPERATION, handler: (accessor, params) => { const selectionManagerService = accessor.get(SelectionManagerService); - if (!params) { - return false; - } + if (!params) return false; const { selections, type } = params; selectionManagerService.replace(selections, type); diff --git a/packages/sheets/src/services/selection-manager.service.ts b/packages/sheets/src/services/selection-manager.service.ts index 3cb120d746..561b2468dc 100644 --- a/packages/sheets/src/services/selection-manager.service.ts +++ b/packages/sheets/src/services/selection-manager.service.ts @@ -438,8 +438,4 @@ export class SelectionManagerService implements IDisposable { this._refresh(param); } - - // private refreshCurrentSelection(): void { - // this._currentSelection$.next(this._currentSelection); - // } }