Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting permissions #250

Closed
me2000 opened this issue Oct 30, 2019 · 1 comment
Closed

Setting permissions #250

me2000 opened this issue Oct 30, 2019 · 1 comment
Assignees
@dperson

Comments

@me2000
Copy link

me2000 commented Oct 30, 2019 •
edited
Loading

Hi,

I am using the container from a docker-compose file configuring it by setting environment variables. Setting the PERMISSIONS variable I noticed that it didn't seem to do anything. When looking into samba.sh I saw that first perms() is called iterating through /etc/samba/smb.conf and then the SHARE* variables are parsed. So when perms() is called there are no shares configured and so no permissions are set. I had to go into the container after starting it to set the permissions.

I would like to suggest to change the order of variable parsing in samba.sh to make sure that smb.conf is complete before perms() is called.

Cheers, ME
@dperson dperson self-assigned this Oct 30, 2019
@dperson
Copy link
Owner

dperson commented Oct 30, 2019

Thanks! that's a good suggestion. The next build will have it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dperson dperson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dperson @me2000