Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate models built in Spacy to use Stanford models #4

Open
dpalmasan opened this issue Mar 27, 2020 · 5 comments · Fixed by #13
Open

Migrate models built in Spacy to use Stanford models #4

dpalmasan opened this issue Mar 27, 2020 · 5 comments · Fixed by #13
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dpalmasan
Copy link
Owner

dpalmasan commented Mar 27, 2020

With the new release of stanza:

https://stanfordnlp.github.io/stanza/

Maybe it is a good opportunity to improve accuracy. The issue is about investigating if this could improve our accuracy and cost estimates of migration.

@dpalmasan dpalmasan added enhancement New feature or request help wanted Extra attention is needed labels Mar 30, 2020
@brucewlee
Copy link
Contributor

Thank you for open-sourcing this repo! It's helping a lot with my research.

Regrading Stanza migration, unless you have a tight deadline, I could help. However, I doubt the accuracy would improve by much. SpaCy had a major improvement quite recently https://spacy.io/usage/v3. But, of course, Stanza would look much better for research papers.

@dpalmasan
Copy link
Owner Author

Hello Bruce! Sure, I don't have a tight deadline, so your contribution is more than welcome! There are some differences in stanza pre-trained models compared to spacy ones, so maybe I am not sure if completely migrating it, but having the alternative of using stanza models instead of spacy might improve performance in some cases!

@brucewlee
Copy link
Contributor

brucewlee commented Mar 12, 2021

Oh, so do you mean adding an option to use Stanza? Hmm, I'm familiar with both Stanza and spaCy, but the biggest trouble for me would be dealing with Spanish texts. I only know Spanish at a very introductive level.

Anyways, I looked through Entity Grid and TTR features, which both seem to require minimal Spanish skills. I'll first create a pull request (in a few days) for these files. I'll try to add options to use Stanza rather than fully migrate to Stanza. One could then choose which to use.

@dpalmasan
Copy link
Owner Author

I mean, initially I wanted to completely replace spacy, but as you mentioned, spacy improved over time, so maybe removing all the spacy references will not be as good as having options for both stanza and spacy. No worries regarding Spanish related features. I can update them. BTW thanks for your desire to contribute!

@brucewlee
Copy link
Contributor

No worries. I'm also working on a similar project so it'll help me too anyways :)

@dpalmasan dpalmasan linked a pull request Apr 7, 2021 that will close this issue
@dpalmasan dpalmasan added this to To do in Model Loader Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants