Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to entity grid #17

Open
dpalmasan opened this issue Apr 4, 2021 · 1 comment
Open

Add type hints to entity grid #17

dpalmasan opened this issue Apr 4, 2021 · 1 comment
Labels
good first issue Good for newcomers
Milestone
TypeHints

Comments

@dpalmasan
Copy link
Owner

The entity grid module can be found in the following source:

https://github.com/dpalmasan/TRUNAJOD2.0/blob/master/src/TRUNAJOD/entity_grid.py

For example, the function:

def get_local_coherence(egrid):

Could be defined as:

def get_local_coherence(egrid: EntityGrid) -> Tuple[float, float, float, float, float]:
@dpalmasan dpalmasan added this to the TypeHints milestone Apr 4, 2021
@dpalmasan dpalmasan added the good first issue Good for newcomers label Apr 4, 2021
@supersonic1999
Copy link
Contributor

#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
TypeHints
Development

No branches or pull requests
2 participants
@supersonic1999 @dpalmasan