Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppresses CodeQL for BinaryFormatter deserialization for several files #11804

Closed
ricardobossan opened this issue Aug 2, 2024 · 0 comments · Fixed by #11805
Closed

Suppresses CodeQL for BinaryFormatter deserialization for several files #11804

ricardobossan opened this issue Aug 2, 2024 · 0 comments · Fixed by #11805
Assignees
@ricardobossan
Labels
🚧 work in progress Work that is current in progress

Comments

@ricardobossan
Copy link
Member

.NET version

9.0.100-preview.5.24307.3

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

Suppresses CodeQL for BinaryFormatter deserialization for several files:

File : Line Rule ID
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomComponentSerializationService.CodeDomSerializationStore.cs : 228 [SM03722]
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomComponentSerializationService.CodeDomSerializationStore.cs : 228 [SM04191]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/CommandSet.cs : 1868 [SM03722]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/CommandSet.cs : 1868 [SM04191]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/OleDragDropHandler.ComponentDataObject.cs : 142 [SM03722]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/OleDragDropHandler.ComponentDataObject.cs : 142 [SM04191]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/OleDragDropHandler.ComponentDataObject.cs : 214 [SM03722]
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/OleDragDropHandler.ComponentDataObject.cs : 214 [SM04191]
src/System.Windows.Forms/src/System/Resources/ResXDataNode.cs : 449 [SM03722]
src/System.Windows.Forms/src/System/Resources/ResXSerializationBinder.cs : 69 [SM04225]
src/System.Windows.Forms/src/System/Windows/Forms/ActiveX/AxHost.PropertyBagStream.cs : 44 [SM03722]
src/System.Windows.Forms/src/System/Windows/Forms/ActiveX/AxHost.PropertyBagStream.cs : 44 [SM04191]
src/System.Windows.Forms/src/System/Windows/Forms/ActiveX/Control.ActiveXImpl.cs : 1158 [SM03722]
src/System.Windows.Forms/src/System/Windows/Forms/ActiveX/Control.ActiveXImpl.cs : 1158 [SM04191]
src/System.Windows.Forms/src/System/Windows/Forms/OLE/DataObject.ComposedDataObject.NativeDataObjectToWinFormsAdapter.cs : 208 [SM03722]

Steps to reproduce

None
@ricardobossan ricardobossan added the untriaged The team needs to look at this issue in the next triage label Aug 2, 2024
@ricardobossan ricardobossan self-assigned this Aug 2, 2024
@ricardobossan ricardobossan removed the untriaged The team needs to look at this issue in the next triage label Aug 2, 2024
@ricardobossan ricardobossan mentioned this issue Aug 2, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ricardobossan ricardobossan

Labels
🚧 work in progress Work that is current in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress CodeQL for BinaryFormatter deserialization in several files ricardobossan/winforms
1 participant
@ricardobossan