Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValueGenerated.OnUpdateSometimes for shared columns #22225

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Add ValueGenerated.OnUpdateSometimes for shared columns #22225

merged 1 commit into from
Aug 26, 2020

Conversation

AndriySvyryd
Copy link
Member

Fixes #21139

@AndriySvyryd
Copy link
Member Author

@dotnet/efteam New API:

  • ValueGenerated.OnUpdateSometimes
  • PropertyBuilder.ValueGeneratedOnUpdateSometimes()

@smitpatel
Copy link
Member

ValueGenerated.OnUpdateSometimes

😄

ajcvickers
ajcvickers approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% happy with the new name, but no immediate ideas for anything better.

@dotnet/efteam Anybody have suggestions?

@ajcvickers
Copy link
Member

@Pilchie for RC1

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 26, 2020

Could someone add a few words about the SomeTimes part? That may give some ideas for the new name.

@AndriySvyryd
Copy link
Member Author

@ErikEJ In this particular case it indicates that the value will be "generated" by the database when a property that is sharing the column is updated. But since ValueGenerated is in Core the name shouldn't reference any relational concepts. It also might be used to describe other situations.

@Pilchie
Copy link
Member

Pilchie commented Aug 26, 2020

Approved for RC1.

@AndriySvyryd AndriySvyryd merged commit 029ad85 into release/5.0 Aug 26, 2020
@AndriySvyryd AndriySvyryd deleted the Issue21139 branch August 26, 2020 19:02
@AndriySvyryd
Copy link
Member Author

If a better name comes up we'll rename in a separate PR.

This was referenced Aug 27, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when saving value to a shared column
5 participants
@AndriySvyryd @smitpatel @ajcvickers @ErikEJ @Pilchie