Fix to #19023 - Query: Log query plan #19674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Jan 23, 2020
| @@ -17,7 +17,7 @@ namespace Microsoft.EntityFrameworkCore.Query.Internal | |||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | |||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | |||
| /// </summary> | |||
| public class RelationalCommandCache | |||
| public class RelationalCommandCache : IPrintableExpression | |||
There was a problem hiding this comment.
This is not great (at least the name). Alternative I can think of is adding back RelationalExpressionPrinter and some custom classes to print various types of objects wrapped inside ConstantExpression.
Adding interface to RelationalCommandCache seems like the lesser of 2 evils. Thoughts?
There was a problem hiding this comment.
Internal class, so doesn't matter that much
3cfed1c
to
61fcce8
Compare
|
ping/thoughts? |
AndriySvyryd
approved these changes
Feb 4, 2020
Making RelationalCommandCache printable and printing it's SelectExpression.
Example query plan output:
queryContext => new QueryingEnumerable<int>(
(RelationalQueryContext)queryContext,
RelationalCommandCache.SelectExpression(
(Projection Mapping:
EmptyProjectionMember -> 0
SELECT ((COUNT((*))))
FROM (Customers AS c)
WHERE ((c.CustomerID) == (N'ALFKI')))),
null,
ReaderColumn[] { ReaderColumn<int>, },
Func<QueryContext, DbDataReader, ResultContext, int[], ResultCoordinator, int>,
TestModels.Northwind.NorthwindRelationalContext,
DiagnosticsLogger<Query>)
.Single()
Fixes #19023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making RelationalCommandCache printable and printing it's SelectExpression.
Example query plan output:
Fixes #19023