Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose and use async APIs for transaction commit/rollback #20694

Closed
roji opened this issue Apr 20, 2020 · 7 comments · Fixed by #20695
Closed

Expose and use async APIs for transaction commit/rollback #20694

roji opened this issue Apr 20, 2020 · 7 comments · Fixed by #20695
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Apr 20, 2020

Continuing on #9015, #15917
@roji roji self-assigned this Apr 20, 2020
roji added a commit that referenced this issue Apr 20, 2020
@roji
Expose async transaction commit/rollback APIs
1b25fb9 
Closes #20694
@roji roji mentioned this issue Apr 20, 2020
Merged
roji added a commit that referenced this issue Apr 21, 2020
@roji
Expose async transaction commit/rollback APIs
94d95a8 
Closes #20694
roji added a commit that referenced this issue Apr 21, 2020
@roji
Expose async transaction commit/rollback APIs
b999cc6 
Closes #20694
roji added a commit that referenced this issue Apr 21, 2020
@roji
Expose async transaction commit/rollback APIs (#20695)
1e977ae 
Closes #20694
@roji roji changed the title Expose missing async APIs for transaction commit/rollback Expose and use async APIs for transaction commit/rollback Jul 28, 2020
@roji
Copy link
Member Author

roji commented Jul 28, 2020

@ajcvickers shouldn't this be in a 5.0 milestone? It seemed to have gone in for preview5...

@roji roji mentioned this issue Jul 28, 2020
Closed
@AndriySvyryd
Copy link
Member

@roji Usually the person that commits the fix is responsible of ensuring that the issue is in the correct milestone and has the "closed-fixed" label

@roji
Copy link
Member Author

roji commented Jul 28, 2020

Sure, am just wondering why this didn't pop up for triage up to now...

@roji roji added this to the 5.0.0-preview5 milestone Jul 28, 2020
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 28, 2020
@AndriySvyryd
Copy link
Member

We don't triage closed issues

@roji
Copy link
Member Author

roji commented Jul 28, 2020

We had a few issues with closed-fixed without a milestone - fixed two of mine, pinged @ajcvickers for others. Unfortunately Github doesn't seem to support searching for issues without a certain label (closed-duplicate and all the others), so it's difficult to find everything that doesn't have a closed label but no milestone...

@smitpatel
Copy link
Member

GH does not properly filter things but here is the query you are looking for
https://github.com/dotnet/efcore/issues?q=is%3Aissue+no%3Amilestone+is%3Aclosed+-label%3Aclosed-duplicate+-label%3Aclosed-question+-label%3Aclosed-external+-label%3Aclosed-by-design+-label%3Aclosed-could-not-reproduce+-label%3Aclosed-not-needed+-label%3Aclosed-wont-fix

Plus, don't think there is any need to go further than first page as we did not assign closed-* labels before. First page end itself is reaching 2018.

@roji
Copy link
Member Author

roji commented Jul 29, 2020

Thanks @smitpatel!

@ajcvickers ajcvickers modified the milestones: 5.0.0-preview5, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Expose async transaction commit/rollback APIs dotnet/efcore
4 participants
@ajcvickers @smitpatel @roji @AndriySvyryd