MacOS/Windows bug with Daemon/Coordinator on 0.3.5rc0

[Hennzau]

Describe the bug

When I launch a dataflow where a node is dynamic, I can't stop it; no crash of coordinator or daemon (CTRL+C if attached, dora stop if detached).

To Reproduce
Steps to reproduce the behavior:

1. Dora start daemon: dora up
2. Start a new dataflow: dora start dataflow.yaml (optional: --detach)
3. Stop dataflow: dora stop / CTRL+C
   At this step it blocks until I do:
4. Destroy dataflow: dora destroy

On windows, i can only tell that when i want to do dora stop it blocks. Because CTRL+C in attached mode always make the coordinator crash

Environments (please complete the following information):

• System info: MacOS
• Dora version: 0.3.5rc0

[Hennzau]

on windows I have this error in dora-coordinator output file:

2024-07-01T19:56:46.554799Z ERROR dora_coordinator::control: failed to send reply
2024-07-01T19:56:46.554844Z ERROR dora_coordinator::control: failed to send reply

[haixuanTao]

I'm unable to reproduce. I get the following behaviour:

2024-07-03.08-35-07.mp4

Are you saying that the dynamic node is not stopping? Or that the dataflow is not stopping?

P.S: Sorry the screen recording only recorded half of the screen.

[Hennzau]

Hi, it's the dataflow that is not stopping. Even if I don't run the dynamic node, i'm unable to stop the dataflow. Here is a record:

Enregistrement.de.l.ecran.2024-07-03.a.08.48.19.mov

[haixuanTao]

So I think that you might need to start the dynamic node first before stopping the dataflow. I think not starting the dataflow is going to make it impossible to stop a not started dataflow.

I think we should fix this but this might be your error.

[phil-opp]

I opened #583 with a potential fix. Perhaps you could give it a try if you have time, @Hennzau?

[Hennzau]

I opened #583 with a potential fix. Perhaps you could give it a try if you have time, @Hennzau?

Hi! It works now! Thanks