Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are definitions manually fixed? #48

Closed
neochief opened this issue Nov 6, 2018 · 1 comment
Closed

Are definitions manually fixed? #48

neochief opened this issue Nov 6, 2018 · 1 comment

Comments

@neochief
Copy link

neochief commented Nov 6, 2018

When I found this repository, I thought that you can generate the same but up-to-date TS definitions with this script: https://github.com/pravdomil/ExtendScript-XML-to-TypeScript

However, by doing so and comparing results, I noticed that resulting files differ. For example, the general/JavaScript.d.ts definition contains interfaces for all standard stuff, whereas if you generate the same file with the abovementioned script, you'll get standard stuff declared as classes.

Apparently, the generator script is either outdated or some files, such as javascript.xml, are supposed to be manually fixed to be compatible with other definitions in this repository.

Could you please clarify this? Is there a newer version of the generator script?

@pravdomil
Copy link
Collaborator

pravdomil commented Nov 6, 2018

some files, such as JavaScript.d.ts, are manualy fixed to be compatible with other definitions in this repository and xml files have bugs see https://github.com/pravdomil/Types-for-Adobe/commits/master/shared/JavaScript.d.ts or https://github.com/pravdomil/Types-for-Adobe/commits/master/Illustrator/2015.3/index.d.ts

see commit history for each definition

@pravdomil pravdomil changed the title Generator scripts? Are definitions manually fixed? Nov 13, 2018
@pravdomil pravdomil reopened this Nov 13, 2018
@zlovatt zlovatt closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants