Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe version upgrade? #110

Open
MIJOTHY opened this issue Jan 22, 2019 · 1 comment
Open

Stripe version upgrade? #110

MIJOTHY opened this issue Jan 22, 2019 · 1 comment

Comments

@MIJOTHY
Copy link

MIJOTHY commented Jan 22, 2019

From the readme it looks like there are intentions to increment the hard-coded API version:

All versioning is hard-coded (for safety) to version 2014-10-07. Stripe API versions specified in the HTTP headers of Stripe requests take precedence over the API version specified in your Stripe Dashboard. In an attempt to ensure API consistency and correct parsing of returned JSON, all Stripe versions are hard-coded, and are inaccessible to the end-users of this library. When a new Stripe API version is released this library will increment the hard-coded API version.

Are there any plans to do this (or guidelines for pull requests for version bumps)? From this issue it looks like we can use stripeRaw to define our own extensions to the library. However, the issue with staying with an old version for users is that, from the Stripe docs.

API versions can’t be downgraded. You should regularly release new versions of your library to correctly handle any changes to JSON responses.

To my knowledge, if a user creates a Stripe account, they are automatically put on the latest version of the API (currently 2018-11-08) While the library works and hits the 2014 version as defined in the http-client, it means the user can't see account activity on the dashboard (and presumably this means they can't perform actions on these requests).

Are there any plans for/would PR's be accepted for (1) parameterising the Stripe lib by version (with a default to the current 2014 default), (2) bumping the version, and/or (3) having different branches for different versions?

Thanks.

@NorfairKing
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants