Feat/1331 disables deduplication for incremental #1892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables deduplication for the test case described by ingestr here: #971 (comment)
Related Issues
merge
write disposition #1131Questions
@rudolfix
merge
write disposition #1131 . Are they already implemented in this PR?tests/extract/test_incremental.py::test_deduplication_on_write_disposition_not_merge
makes sense at all because onwrite_disposition="replace"
the table is truncated before the load. I included it because the ticket speaks of the merge write disposition so I wanted to test the opposite too. Feel free to drop this commit.last_value
superfluous?TODO after merge