Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page Still Has Route Cards #984

Open
1 task done
jtfairbank opened this issue Mar 6, 2023 · 1 comment
Open
1 task done

Home Page Still Has Route Cards #984

jtfairbank opened this issue Mar 6, 2023 · 1 comment
Labels
bug Something isn't working triage An issue needs further analysis by a team member

Comments

@jtfairbank
Copy link
Contributor

What happened?

@wwwwwlwwwww took the Route links off of the main menu, but the home page still has a section w/ route cards for uK > France and UK > Lebanon. Should we hide that section as well, or replace it with something else?

Steps to reproduce

  1. Go to https://distributeaid.org/
  2. Scroll down to the section with 3 card components.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jtfairbank jtfairbank added bug Something isn't working triage An issue needs further analysis by a team member labels Mar 6, 2023
@wwwwwlwwwww
Copy link
Collaborator

@jtfairbank Ah good catch, that was an oversight on my part not thinking about the routes also being featured on the home page.

My proposed solution would be to just hide the section with the three cards, so that "How we help" would appear directly under the section with the spinning globe and social media buttons. I'm not sure if there's a way in code to basically just hide this section without deleting the underlying code in case we bring it back later when the routes are more active--well, I know that this could be done by just commenting out all those lines of code but this isn't very elegant and probably not a best practice. Anyway, hiding rather than deleting should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage An issue needs further analysis by a team member
Projects
None yet
Development

No branches or pull requests

2 participants