Add Kubernetes example cluster naming and test_url output #695
Conversation
kriswuollett
commented
Sep 14, 2021
- Fixes cluster naming by replacing data dependency with an injected variable (fixes examples/kubernetes can't be modified to use a static cluster name #693)
- Gives a name to load balancer, otherwise it is random (resolves Setting LB annotations in Kubernetes example would be helpful #691)
- Output test_url to easily click and check that the example has worked (resolves Kubernetes example should be able to output LoadBalancer external IP #692)
- Add increased timeout for the NGINX ingress Helm chart (fixes Helm chart in Kubernetes example can time out #694)
- Replaced inter-module data dependency with a primary_cluster object variable
- Added wait_for_jobs to nginx_ingress to hope that external IP is available; otherwise apply may fail since the load_balancer ingress wouldn't have any IP addresses yet.
- The default 5 minute timeout sometimes is not enough for this demo; otherwise, resource creation will "fail" due to timing out.
|
OK with merges that address multiple issues, or prefer breaking these into separate pull requests? |
- IP address assignement does not appear to be linked to Helm jobs
|
Hey @kriswuollett, thanks for finding and reporting those issues with the examples. And big thanks for spending time providing this contribution to suggest solutions to them. This PR has some changes that would spark further conversation which can block other fixes from being accepted since they're grouped together. (Specifically changing the cluster-related outputs). If the solutions aren't tied to each other, I do think it makes sense to split them into separate pull requests to move the other fixes along. |
|
@scotchneat, sure I'll split these up. Thanks for taking a look! |
|
plus one on this, it saved me when I needed a static cluster name |
|
@smitt04, fyi, it is unlikely I will find time to split this draft PR. Feel free to take what's here and updated as needed to get it merged in a new PR if you wish. |