Image attribute #565
Merged
Image attribute #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rienafairefr
force-pushed
the
image-attribute
branch
from
024568b
to
bcaa57a
Compare
|
with the latest fixups, acceptance tests are passing |
This was referenced Feb 2, 2021
Closed
|
Hey, @rienafairefr - Thanks a ton for this sweet PR! 😄 Would you please shoot me an email when you get a chance? |
andrewsomething
added a commit
that referenced
this pull request
Apr 26, 2021
* image attribute * try adding acceptance test * fixup! image attribute * Update digitalocean/resource_digitalocean_app_test.go Co-authored-by: Andrew Starr-Bochicchio <[email protected]> * test acc image in its own function * move 'image' attribute to service/worker, exclude from static_site * fixup acceptance test * Remove commented out line. Co-authored-by: Andrew Craven <[email protected]> Co-authored-by: Matthieu Berthomé <[email protected]> Co-authored-by: Andrew Starr-Bochicchio <[email protected]> Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the
imageattribute thing from #544, and added acceptance tests which are still running so not sure they pass, this might still not be fully ready, but hey, figure I'd try.