Docs update and custom image options update #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noel Georgi <[email protected]>
frezbo
changed the title
| _, _, err := client.Images.Update(ctx, id, &godo.ImageUpdateRequest{ | ||
| Name: name, | ||
| }) | ||
| if d.HasChanges("name", "description", "distribution") { |
There was a problem hiding this comment.
👀 Hadn't noticed they've introduced HasChanges. Much nicer than the old if d.HasChange("foo") || d.HasChange("bar") syntaxt.
Comment on lines
184
to
197
| imageUpdateRequest := &godo.ImageUpdateRequest{} | ||
|
|
||
| if d.HasChange("name") { | ||
| imageUpdateRequest.Name = imageName | ||
| } | ||
| if d.HasChange("distribution") { | ||
| imageDistribution := d.Get("distribution").(string) | ||
| imageUpdateRequest.Distribution = imageDistribution | ||
| } | ||
|
|
||
| if d.HasChange("description") { | ||
| imageDescription := d.Get("description").(string) | ||
| imageUpdateRequest.Description = imageDescription | ||
| } |
There was a problem hiding this comment.
Suggested change
| imageUpdateRequest := &godo.ImageUpdateRequest{} | |
| if d.HasChange("name") { | |
| imageUpdateRequest.Name = imageName | |
| } | |
| if d.HasChange("distribution") { | |
| imageDistribution := d.Get("distribution").(string) | |
| imageUpdateRequest.Distribution = imageDistribution | |
| } | |
| if d.HasChange("description") { | |
| imageDescription := d.Get("description").(string) | |
| imageUpdateRequest.Description = imageDescription | |
| } | |
| imageUpdateRequest := &godo.ImageUpdateRequest{ | |
| Name: imageName, | |
| Distribution: d.Get("distribution").(string), | |
| Description: d.Get("description").(string), | |
| } | |
We can simplify this a bit. PUT is idempotent, so no reason not to build the full request.
There was a problem hiding this comment.
I didn't noticed it was idempotent, was trying to change only fields that changed. I'll make this change
|
@andrewsomething I'll add a test for |
andrewsomething
approved these changes
Jan 13, 2021
|
@andrewsomething I'm so sorry. I forgot about this. Thanks for taking it up 👍 ❤️ |
andrewsomething
added a commit
that referenced
this pull request
Apr 26, 2021
* Docs update and custom image options update support Signed-off-by: Noel Georgi <[email protected]> * Apply review suggestion. * Add an acceptance test for updates. Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noel Georgi [email protected]
descriptionanddistributionfrom images: Support updating distribution and description. godo#413