Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: unify on BioStructures for PDB reading #77

Open
timholy opened this issue Jun 6, 2024 · 2 comments
Open

Goal: unify on BioStructures for PDB reading #77

timholy opened this issue Jun 6, 2024 · 2 comments

Comments

@timholy
Copy link
Contributor

timholy commented Jun 6, 2024

There's a growing ecosystem for handling protein structure in Julia, including two visualization packages https://github.com/MurrellGroup/ProtPlot.jl and https://github.com/BioJulia/BioMakie.jl, neither of which supports the representation used by MIToS.

I started a conversation on the Julia slack (@diegozea was invited) about unifying around a single reader for PDB files, and the conversation has spilled out to public fora like BioJulia/BioStructures.jl#48. I propose that common reader be BioStructures, and that package has undergone several recent changes to make it more palatable as a common foundation. Regardless of what decision we end up making, I think it makes a lot of sense for Julia to have a common PDB reader so that everyone can leverage all the cool tools. In my opinion, MIToS is a bit "heavy" (it does so many things which I love!) for it to serve well as the common reader that everybody depends on. That would mean migrating MIToS to work with the format read by BioStructures. Alternatively, if the community ends up preferring the MIToS representation, one could split out the PDB component of MIToS into a smaller, standalone package.

Feel free to comment here or elsewhere about any obstacles, technical or otherwise, that would stand in the way of converging on a common core.

@diegozea
Copy link
Owner

Hi @timholy!

Once BioStructures releases its new version, I will add it as an MIToS dependency to read mmCIF files and easily integrate them with other packages in the ecosystem. I will keep the flat MIToS structure representation, as it has some performance benefits for some operations and makes it easy to work at the residue level. But, I will possibly re-export some BioStructures functionality and add methods to convert between both representations so that MIToS structures can be visualized using those tools—or maybe add them as package extensions. What do you think about that plan?

Cheers,

@diegozea
Copy link
Owner

Hi @timholy ! MIToS 3.0 now has BioStructures as a dependency and adds the MMCIFFile format to read mmCIF files. I also add a conversion between Vector{PDBResidue} and BioStructures.MolecularStructure. I think this should help allow for sharing tools more easily between MIToS and BioStructures. I have not moved the PDBFile parser, as I guess using the one on BioStructures and then converting the object will be slower/more costly. So, for the moment, I am keeping the MIToS PDB parser, but I should benchmark that in the future. Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants