Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: frame length (86400) less than expected (115200) #19

Closed
Sean-Der opened this issue Jul 15, 2019 · 10 comments
Closed

panic: frame length (86400) less than expected (115200) #19

Sean-Der opened this issue Jul 15, 2019 · 10 comments
Labels
bug Something isn't working
Projects

Comments

@Sean-Der
Copy link
Contributor

This is on my Mac

Version 10.13.6
Macbook Pro (13-inch, 2017)

@maxhawkins
Copy link
Collaborator

Thanks for reporting. Do you know what triggered it?

@Sean-Der
Copy link
Contributor Author

This is right on startup! This also always had the visual corruption.

I don't know the AVFoundation APIs, is it possible that you aren't getting back the pix_fmt you expect?

@maxhawkins
Copy link
Collaborator

The camera doesn't activate until the intro animation is done. Could it be the ivf reader for the intro?

@Sean-Der
Copy link
Contributor Author

Sorry right on startup for the camera, the videos do play correctly!

@maxhawkins
Copy link
Collaborator

Good to know!

I bet the camera doesn't support the dimensions we request and is sending different ones. I'll look into this...

@Sean-Der
Copy link
Contributor Author

Oh good idea.

If you have any debugging code I can run send it my way and can test it out!

@maxhawkins maxhawkins added the bug Something isn't working label Jul 15, 2019
@maxhawkins maxhawkins added this to To do in v1.0 Jul 16, 2019
@maxhawkins
Copy link
Collaborator

It appears #25 and this issue are related.

When I launched Photo Booth I got this error

@maxhawkins
Copy link
Collaborator

  1. This should return an error rather than panicking
  2. Maybe this has to do with the image dimensions changing to an unexpected size

@maxhawkins
Copy link
Collaborator

Possible solution to 1)

Pass the frame size in the cam_avfoundation callback. If it's different than expected the code will scale it anyway.

@maxhawkins
Copy link
Collaborator

This may be fixed by 27609cf

@maxhawkins maxhawkins moved this from To do to Done in v1.0 Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
v1.0
  
Done
Development

No branches or pull requests

2 participants