Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): set react resolution #620

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Apr 4, 2024

After the previous change in #619, there is still an infinite loop, but it looks different.

One hypothesis is that there is still a circular dependency causing this, which could be between the app-platform and UI, as mentioned in the platform DevEx meeting. Another hypothesis is that a failure to resolve a dependency could cause the infinite loop, which is mentioned in an NPM bug report. The last time, it could have been a failure to resolve a @dhis2/cli-app-scripts version; this time, it could be a failure to resolve a react and react-dom version -- here's some logs that make me think so:

2383 silly placeDep node_modules/@dhis2/cli [email protected] OK for: @dhis2/[email protected] want: ^16.8.6
2384 silly placeDep node_modules/@dhis2/cli [email protected] REPLACE for: [email protected] want: ^16.14.0
....
2455 silly placeDep node_modules/@dhis2/cli [email protected] REPLACE for: @dhis2/[email protected] want: 16.8
2456 silly placeDep ROOT [email protected] OK for: @dhis2/[email protected] want: 16.8
2457 silly placeDep ROOT [email protected] OK for: [email protected] want: ^16.0.0

My hope is that setting a resolution field for a specific react and react-dom version will override the conflicting dependency requirements 🤞

Result update: It did not

@KaiVandivier KaiVandivier merged commit 90e4ea4 into alpha Apr 4, 2024
5 checks passed
@KaiVandivier KaiVandivier deleted the libs-587-set-react-resolution branch April 4, 2024 12:29
dhis2-bot added a commit that referenced this pull request Apr 4, 2024
## [4.2.5-alpha.2](v4.2.5-alpha.1...v4.2.5-alpha.2) (2024-04-04)

### Bug Fixes

* **deps:** set react resolution ([#620](#620)) ([90e4ea4](90e4ea4))
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants