Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't update the package.json version before npm stage #25

Merged
merged 3 commits into from
Mar 25, 2019
Merged

fix: don't update the package.json version before npm stage #25

merged 3 commits into from
Mar 25, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 25, 2019 •
edited
Loading

Pass NPM_CONFIG_ALLOW_SAME_VERSION to npm publish so it doesn't fail when we've already updated the package.json version in the updateDeps plugin.

@amcgee amcgee requested a review from varl March 25, 2019 10:33
varl
varl approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it flies!

@amcgee
Copy link
Member Author

amcgee commented Mar 25, 2019

🐦

@amcgee amcgee merged commit 5909f78 into master Mar 25, 2019
dhis2-bot pushed a commit that referenced this pull request Mar 25, 2019
chore(release): cut 0.13.0 [skip ci]
7dee423 
# [0.13.0](v0.12.1...v0.13.0) (2019-03-25)

### Bug Fixes

* don't update the package.json version before npm stage ([#25](#25)) ([5909f78](5909f78))

### Features

* semantic release update deps ([#24](#24)) ([d2c155e](d2c155e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@amcgee amcgee deleted the fix/dont-update-version-before-npm branch March 25, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varl varl varl approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcgee @dhis2-bot @varl