Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: semantic release update deps #24

Merged
merged 9 commits into from
Mar 25, 2019
Merged

feat: semantic release update deps #24

merged 9 commits into from
Mar 25, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 23, 2019 •
edited
Loading

So... I may have gone a little overboard but I think this gets us all the way there.

This looks through glob patterns in the workspaces property of the root package.json. It then loops through all the package.jsons it can find and updates local dependencies (other packages found in the workspace) to nextRelease.version (using a ^ range). It also updates the version property in each package.json, including the root.

Right now this will try to publish the root package as well, which should fail because it's private. We might want to filter out private repos before trying to publish them (or at least omit the root one in this specific case). = done

Also - I don't think we're actually updating the yarn.lock files anywhere, but this should find and push them all in the git stage if they've changed

Now time for 🛌

@amcgee amcgee requested a review from varl March 23, 2019 01:25
varl
varl suggested changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I saw a few things which needs to be fixed but this looks really good! 🙇‍♂️

packages/d2-app/src/commands/scripts/release.js Outdated Show resolved Hide resolved
packages/d2-app/src/commands/scripts/release.js Outdated Show resolved Hide resolved
packages/d2-app/src/commands/scripts/support/semantic-release-update-deps.js Outdated Show resolved Hide resolved
packages/d2-app/src/commands/scripts/release.js Show resolved Hide resolved
@amcgee
Copy link
Member Author

amcgee commented Mar 25, 2019

@varl thanks for the review, nice catches! Fixed them now.

@amcgee amcgee requested a review from varl March 25, 2019 09:35
varl
varl previously approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Well done. 👍

@amcgee amcgee merged commit d2c155e into master Mar 25, 2019
dhis2-bot pushed a commit that referenced this pull request Mar 25, 2019
chore(release): cut 0.13.0 [skip ci]
7dee423 
# [0.13.0](v0.12.1...v0.13.0) (2019-03-25)

### Bug Fixes

* don't update the package.json version before npm stage ([#25](#25)) ([5909f78](5909f78))

### Features

* semantic release update deps ([#24](#24)) ([d2c155e](d2c155e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@amcgee amcgee deleted the feat/semantic-release-update-deps branch March 25, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varl varl varl approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcgee @dhis2-bot @varl