chore(deps): update shell to ui@9 #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Updated major version of UI
kabaros
approved these changes
Jan 25, 2024
KaiVandivier
requested changes
Jan 26, 2024
There was a problem hiding this comment.
I think as-is, this would need to be released as a breaking change because it would actually break builds unless the consumer changes something (upgrades the rest of the app to ui@^9, uses a resolution, or uses the --no-verify tag) -- here's an example of an app with a dependency on ui@^8: (the "Yes" option from the prompt doesn't work either)
It may be an option to change how that package validation works though 🤷♂️
|
@KaiVandivier The commit has |
KaiVandivier
approved these changes
Jan 30, 2024
dhis2-bot
added a commit
that referenced
this pull request
Mar 5, 2024
# [11.0.0](v10.5.0...v11.0.0) (2024-03-05) ### chore * **deps:** update shell to ui@9 ([#824](#824)) ([b6a12fa](b6a12fa)) ### BREAKING CHANGES * **deps:** Updated major version of UI
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically this should be a breaking change, since we update the major version of a dependency. However the changes in UI are not really changes that should affect people - just some removed proptypes - nevertheless they were part of the public API.
BREAKING CHANGE: Updated major version of UI