fix: move precache route handler to reenable navigation handler on login redirects [LIBS-473] #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birkbjo
approved these changes
May 16, 2023
dhis2-bot
added a commit
that referenced
this pull request
May 16, 2023
## [10.3.9](v10.3.8...v10.3.9) (2023-05-16) ### Bug Fixes * move precache route to reenable navigation handler on login redirects [LIBS-473] ([#809](#809)) ([1ff29b6](1ff29b6))
|
🎉 This PR is included in version 10.3.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Aug 10, 2023
# [10.4.0-alpha.3](v10.4.0-alpha.2...v10.4.0-alpha.3) (2023-08-10) ### Bug Fixes * move precache route to reenable navigation handler on login redirects [LIBS-473] ([#809](#809)) ([1ff29b6](1ff29b6)) * **pwa:** avoid crashing when SW is not available [LIBS-499] ([#807](#807)) ([b681022](b681022)) * omit `moment-locales` from precache ([#806](#806)) ([c8d5494](c8d5494)) * **cli:** fix envs to fix plugins in dev ([#799](#799)) ([ba29cea](ba29cea)) * **plugins:** omit launch paths when unused [LIBS-477] ([#791](#791)) ([e49a51f](e49a51f)) * **pwa:** bump ui version for headerbar connection status [LIBS-315] ([#797](#797)) ([61ff0a4](61ff0a4)) * make loading placeholders transparent ([#795](#795)) ([6e64756](6e64756)) * **plugins:** inject precache manifest correctly ([#792](#792)) ([c0d172e](c0d172e)) * **pwa:** add config option to omit files from precache [LIBS-482] ([#793](#793)) ([d089dda](d089dda))
|
🎉 This PR is included in version 10.4.0-alpha.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-473
The routing for the "plugin precache manifest" seems to be interfering with the route to handle navigation events, which prevents the service worker from passing redirect responses to the client when the user is unauthenticated. This results in seeing the login modal when visiting a PWA app while logged out, instead of being redirected to the login page
Moving the plugin precache route handler to come after the navigation handler lets the nav. route handler send redirects to the client, letting the login page be shown correctly
Test
This can be tested by checking out this branch and building the PWA example app:
Then, upload the example PWA app to an instance and visit the app. Make sure the PWA app is installed or updated -- check the user profile menu for more information.
Log out or delete the session cookie, then visit the app URL. If it's successful, you should be redirected to the login page, instead of seeing a login modal at the PWA app URL