Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make loading placeholders transparent #795

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

KaiVandivier
Copy link
Contributor

Requested by the Analytics team (@edoardo)

From @HendrikThePendric:

Makes perfect sense to remove it. The main purpose of the translucent layer is to visually indicate that the content below is unreachable. If there is no content below, just showing a transparent layer is preferable.

More history: slack thread

@KaiVandivier KaiVandivier merged commit 6e64756 into master Mar 16, 2023
@KaiVandivier KaiVandivier deleted the fix-transparent-loading-mask branch March 16, 2023 16:02
dhis2-bot added a commit that referenced this pull request Mar 16, 2023
## [10.3.4](v10.3.3...v10.3.4) (2023-03-16)

### Bug Fixes

* make loading placeholders transparent ([#795](#795)) ([6e64756](6e64756))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Aug 10, 2023
# [10.4.0-alpha.3](v10.4.0-alpha.2...v10.4.0-alpha.3) (2023-08-10)

### Bug Fixes

* move precache route to reenable navigation handler on login redirects [LIBS-473] ([#809](#809)) ([1ff29b6](1ff29b6))
* **pwa:** avoid crashing when SW is not available [LIBS-499] ([#807](#807)) ([b681022](b681022))
* omit `moment-locales` from precache ([#806](#806)) ([c8d5494](c8d5494))
* **cli:** fix envs to fix plugins in dev ([#799](#799)) ([ba29cea](ba29cea))
* **plugins:** omit launch paths when unused [LIBS-477] ([#791](#791)) ([e49a51f](e49a51f))
* **pwa:** bump ui version for headerbar connection status [LIBS-315] ([#797](#797)) ([61ff0a4](61ff0a4))
* make loading placeholders transparent ([#795](#795)) ([6e64756](6e64756))
* **plugins:** inject precache manifest correctly ([#792](#792)) ([c0d172e](c0d172e))
* **pwa:** add config option to omit files from precache [LIBS-482] ([#793](#793)) ([d089dda](d089dda))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.4.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants