fix(plugins): fix file loader behavior [LIBS-399] #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenniferarnesen has confirmed that this fix works in the maps app 👍 (see the slack thread mentioned in the Jira issue above) |
| exclude: [ | ||
| /^$/, |
There was a problem hiding this comment.
I believe this newly added regex only matches an empty string. I wonder if this is actually useful, or perhaps a remnant of some early stage experimentation.....
Could you explain why this is needed here?
HendrikThePendric
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
I'm approving after a brief discussion on Slack. @KaiVandivier and I both do not fully understand why it might be useful to exclude empty strings in the file loader. But since CRA also include this one, we might as well do the same.
dhis2-bot
added a commit
that referenced
this pull request
Feb 16, 2023
## [10.2.3](v10.2.2...v10.2.3) (2023-02-16) ### Bug Fixes * **plugins:** fix file loader behavior ([#779](#779)) ([dcdd918](dcdd918))
|
🎉 This PR is included in version 10.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dhis2.atlassian.net/browse/LIBS-399
It seems like the
file-loaderis mangling the css file from maplibre-gl (which doesn’t need compiling, strangely) and outputting all kinds of nasty junk that doesn’t work, like:static/media/javascript,__webpack_public_path__=….binstatic/media/svg+xml;base64,ASD:LKFDNAJKSD….bin.binfilesIn the maps app, this caused an "Filename too long" error that prevented building the app, and
svgicons were broken when run in dev mode.Changing to the modern asset/resource "file loader" seems to fix it with no noticeable side effects.
This configuration was originally what I used when first making plugins, but I seem to remember there was a reason not to use it -- I think it had to do with CSS modules, but this config seems to be running and building fine in the PWA test app, the LL app, and the Maps app, so I don't see any reason not to use it now 🤷♂️