Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve plugin builds #749

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Sep 22, 2022

Addresses a few issues:

  • SW registration URL wasn't working for plugins in development mode
  • Static assets don't get cached at all in dev mode if the "don't cache" URL filter is *

Working on now:

  • CSS modules in the Line Listing app's plugin build are broken after switching from loader: require('file-loader') to type: 'asset/resource' 🤔

@KaiVandivier KaiVandivier marked this pull request as ready for review September 26, 2022 20:28
@KaiVandivier KaiVandivier merged commit b3b317c into alpha Sep 26, 2022
@KaiVandivier KaiVandivier deleted the TECH-474-fix-cli-plugin-build-errors branch September 26, 2022 20:38
dhis2-bot added a commit that referenced this pull request Sep 26, 2022
# [10.1.0-alpha.6](v10.1.0-alpha.5...v10.1.0-alpha.6) (2022-09-26)

### Bug Fixes

* **cli:** improve plugin builds ([#749](#749)) ([b3b317c](b3b317c))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.1.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Oct 20, 2022
# [10.2.0-alpha.1](v10.1.0...v10.2.0-alpha.1) (2022-10-20)

### Bug Fixes

* **cli:** improve plugin builds ([#749](#749)) ([b3b317c](b3b317c))
* add missing webpack dependencies to cli package ([9e58c58](9e58c58))
* **cli:** update webpack plugin options ([d084b44](d084b44))
* casing ([ff5aa6b](ff5aa6b))
* handle webpack errors as described in https://webpack.js.org/api/node/\#error-handling ([c557534](c557534))
* plugin placeholder ([1eea12c](1eea12c))

### Features

* **cli:** add pwa to plugins; fix plugin build details ([#746](#746)) ([fd920a4](fd920a4))
* include plugin launch path plugin.html in built manifests [LIBS-346] ([#745](#745)) ([8843f6b](8843f6b))
* **adapter:** don't render headerbar for plugins ([4ac6d54](4ac6d54))
* **cli:** add webpack config for JS and CSS ([a04b7c6](a04b7c6))
* **cli:** add webpack config for JS and CSS ([cec6339](cec6339))
* **cli:** create plugin entrypoint wrapper during compilation ([8e4dbff](8e4dbff))
* **cli:** enable split chunks optimisation in webpack config ([e8ebcbf](e8ebcbf))
* **cli:** plugin start script ([9fea158](9fea158))
* **cli:** setup css minimiser webpack plugin ([3f1b1f2](3f1b1f2))
* **cli:** setup define webpack plugin ([5d8f374](5d8f374))
* **cli:** setup htmlwebpackplugin ([202225c](202225c))
* **cli:** setup ignore webpack plugin for moment.js ([223b191](223b191))
* **cli:** setup terser webpack plugin ([2693258](2693258))
* webpack config for plugin ([3e4275c](3e4275c))
* **cli:** support plugin entrypoint when validating entrypoints ([04ece0a](04ece0a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.2.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Nov 30, 2022
# [10.2.0](v10.1.6...v10.2.0) (2022-11-30)

### Bug Fixes

* **cli:** improve plugin builds ([#749](#749)) ([b3b317c](b3b317c))
* add missing webpack dependencies to cli package ([9e58c58](9e58c58))
* **cli:** update webpack plugin options ([d084b44](d084b44))
* casing ([ff5aa6b](ff5aa6b))
* handle webpack errors as described in https://webpack.js.org/api/node/\#error-handling ([c557534](c557534))
* plugin placeholder ([1eea12c](1eea12c))

### Features

* **cli:** add pwa to plugins; fix plugin build details ([#746](#746)) ([fd920a4](fd920a4))
* include plugin launch path plugin.html in built manifests [LIBS-346] ([#745](#745)) ([8843f6b](8843f6b))
* **adapter:** don't render headerbar for plugins ([4ac6d54](4ac6d54))
* **cli:** add webpack config for JS and CSS ([a04b7c6](a04b7c6))
* **cli:** add webpack config for JS and CSS ([cec6339](cec6339))
* **cli:** create plugin entrypoint wrapper during compilation ([8e4dbff](8e4dbff))
* **cli:** enable split chunks optimisation in webpack config ([e8ebcbf](e8ebcbf))
* **cli:** plugin start script ([9fea158](9fea158))
* **cli:** setup css minimiser webpack plugin ([3f1b1f2](3f1b1f2))
* **cli:** setup define webpack plugin ([5d8f374](5d8f374))
* **cli:** setup htmlwebpackplugin ([202225c](202225c))
* **cli:** setup ignore webpack plugin for moment.js ([223b191](223b191))
* **cli:** setup terser webpack plugin ([2693258](2693258))
* webpack config for plugin ([3e4275c](3e4275c))
* **cli:** support plugin entrypoint when validating entrypoints ([04ece0a](04ece0a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants